From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TbTss-0007b6-CW
	for qemu-devel@nongnu.org; Thu, 22 Nov 2012 05:19:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TbTso-0000Fl-27
	for qemu-devel@nongnu.org; Thu, 22 Nov 2012 05:19:50 -0500
Received: from mail-ee0-f45.google.com ([74.125.83.45]:49645)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TbTsn-0000FC-SX
	for qemu-devel@nongnu.org; Thu, 22 Nov 2012 05:19:45 -0500
Received: by mail-ee0-f45.google.com with SMTP id d49so4762551eek.4
	for <qemu-devel@nongnu.org>; Thu, 22 Nov 2012 02:19:45 -0800 (PST)
Date: Thu, 22 Nov 2012 11:19:42 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121122101942.GF7598@stefanha-thinkpad.redhat.com>
References: <1353565548-10010-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1353565548-10010-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH for 1.3 v2] block: Fix regression for MinGW
 (assertion caused by short string)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Thu, Nov 22, 2012 at 07:25:48AM +0100, Stefan Weil wrote:
> The local string tmp_filename is passed to function get_tmp_filename
> which expects a string with minimum size MAX_PATH for w32 hosts.
> 
> MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short.
> 
> Commit eba25057b9a5e19d10ace2bc7716667a31297169 introduced this
> regression.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> v2: Added TODO comment as suggested by Stefan Hajnoczi.
> 
> Hi Anthony, hi Blue,
> 
> this fix is needed for 1.3 to avoid a fatal assertion on Windows.
> As discussed on qemu-devel, it is a minimal solution and can be
> replaced by a better one after 1.3.
> 
> Please commit it to git master.
> 
> Regards
> Stefan
> 
> 
>  block.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>