From: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Feng Gao <gf91597@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-or32: Improve float exception
Date: Fri, 23 Nov 2012 02:45:51 +0800 [thread overview]
Message-ID: <20121122184551.GA88520@cs.nctu.edu.tw> (raw)
In-Reply-To: <CAFEAcA_TggZGRqobbRWSPphSWQUdJRuB9cGGeOpmWVDpey4vCg@mail.gmail.com>
> > +void QEMU_NORETURN do_raise_exception_err(OpenRISCCPU *cpu,
> > + uint32_t exception,
> > + uintptr_t pc)
> > +{
> > + TranslationBlock *tb;
> > +#if 1
> > + if (exception < 0x100)
> > + qemu_log("%s: %d\n", __func__, exception);
> > +#endif
>
> Stray debug tracing?
target-mips/op_helper.c also has such "#if 1 .. #endif".
Should we remove it?
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
next prev parent reply other threads:[~2012-11-22 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 2:10 [Qemu-devel] [PATCH] target-or32: Improve float exception Feng Gao
2012-11-22 17:27 ` Peter Maydell
2012-11-22 18:45 ` 陳韋任 (Wei-Ren Chen) [this message]
2012-11-22 19:06 ` Peter Maydell
2012-11-22 18:42 ` 陳韋任 (Wei-Ren Chen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122184551.GA88520@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=gf91597@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).