From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1Tbbmg-0005tI-P2
	for qemu-devel@nongnu.org; Thu, 22 Nov 2012 13:46:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1Tbbmb-0007s4-QL
	for qemu-devel@nongnu.org; Thu, 22 Nov 2012 13:45:58 -0500
Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:64164)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1Tbbmb-0007rz-GN
	for qemu-devel@nongnu.org; Thu, 22 Nov 2012 13:45:53 -0500
Date: Fri, 23 Nov 2012 02:45:51 +0800
From: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= <chenwj@iis.sinica.edu.tw>
Message-ID: <20121122184551.GA88520@cs.nctu.edu.tw>
References: <1353550204-6510-1-git-send-email-gf91597@gmail.com>
	<CAFEAcA_TggZGRqobbRWSPphSWQUdJRuB9cGGeOpmWVDpey4vCg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA_TggZGRqobbRWSPphSWQUdJRuB9cGGeOpmWVDpey4vCg@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-or32: Improve float exception
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Feng Gao <gf91597@gmail.com>, qemu-devel@nongnu.org

> > +void QEMU_NORETURN do_raise_exception_err(OpenRISCCPU *cpu,
> > +                                          uint32_t exception,
> > +                                          uintptr_t pc)
> > +{
> > +    TranslationBlock *tb;
> > +#if 1
> > +    if (exception < 0x100)
> > +        qemu_log("%s: %d\n", __func__, exception);
> > +#endif
>=20
> Stray debug tracing?

  target-mips/op_helper.c also has such "#if 1 .. #endif".
Should we remove it?

Regards,
chenwj

--=20
Wei-Ren Chen (=E9=99=B3=E9=9F=8B=E4=BB=BB)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj