From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tbn5B-0004zw-Qf
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 01:49:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tbn56-0000fX-Vn
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 01:49:49 -0500
Received: from mail-bk0-f45.google.com ([209.85.214.45]:50639)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tbn56-0000fP-PM
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 01:49:44 -0500
Received: by mail-bk0-f45.google.com with SMTP id jk13so2586706bkc.4
	for <qemu-devel@nongnu.org>; Thu, 22 Nov 2012 22:49:43 -0800 (PST)
Date: Fri, 23 Nov 2012 07:49:41 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121123064941.GA22787@stefanha-thinkpad.hitronhub.home>
References: <1353420681-8870-1-git-send-email-brogers@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1353420681-8870-1-git-send-email-brogers@suse.com>
Subject: Re: [Qemu-devel] [PATCH 1.3] Legacy qemu-kvm options have no
	argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: anthony@codemonkey.ws
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Bruce Rogers <brogers@suse.com>

On Tue, Nov 20, 2012 at 07:11:21AM -0700, Bruce Rogers wrote:
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  qemu-options.hx |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9bb29d3..fbcf079 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
>  ETEXI
>  
>  HXCOMM Deprecated by -machine accel=tcg property
> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated by kvm-pit driver properties
> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
>      "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated (ignored)
> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated (ignored)
>  DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
> -- 
> 1.7.7

Anthony, please consider this patch for QEMU 1.3-rc1.  Without it the
deprecated qemu-kvm options don't work!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Stefan