* [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer
@ 2012-11-22 17:30 Jan Kiszka
2012-11-23 11:49 ` [Qemu-devel] for-1.3: " Luiz Capitulino
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jan Kiszka @ 2012-11-22 17:30 UTC (permalink / raw)
To: Anthony Liguori, qemu-devel
Cc: Paolo Bonzini, Dietmar Maurer, Luiz Capitulino
The vm clock may be stopped, and then we won't get open events anymore.
Seen with QMP sessions.
Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
qemu-char.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 88f4025..242b799 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -134,9 +134,9 @@ static void qemu_chr_fire_open_event(void *opaque)
void qemu_chr_generic_open(CharDriverState *s)
{
if (s->open_timer == NULL) {
- s->open_timer = qemu_new_timer_ms(vm_clock,
+ s->open_timer = qemu_new_timer_ms(rt_clock,
qemu_chr_fire_open_event, s);
- qemu_mod_timer(s->open_timer, qemu_get_clock_ms(vm_clock) - 1);
+ qemu_mod_timer(s->open_timer, qemu_get_clock_ms(rt_clock) - 1);
}
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] for-1.3: [PATCH] chardev: Use real-time clock for open timer
2012-11-22 17:30 [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer Jan Kiszka
@ 2012-11-23 11:49 ` Luiz Capitulino
2012-11-24 21:03 ` [Qemu-devel] " Blue Swirl
2012-11-26 21:48 ` Anthony Liguori
2 siblings, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2012-11-23 11:49 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel, Dietmar Maurer
To avoid it getting lost in qemu forest.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer
2012-11-22 17:30 [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer Jan Kiszka
2012-11-23 11:49 ` [Qemu-devel] for-1.3: " Luiz Capitulino
@ 2012-11-24 21:03 ` Blue Swirl
2012-11-26 21:48 ` Anthony Liguori
2 siblings, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2012-11-24 21:03 UTC (permalink / raw)
To: Jan Kiszka
Cc: Paolo Bonzini, Anthony Liguori, Luiz Capitulino, qemu-devel,
Dietmar Maurer
Thanks, applied.
On Thu, Nov 22, 2012 at 5:30 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> The vm clock may be stopped, and then we won't get open events anymore.
> Seen with QMP sessions.
>
> Reported-by: Dietmar Maurer <dietmar@proxmox.com>
> Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> qemu-char.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 88f4025..242b799 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -134,9 +134,9 @@ static void qemu_chr_fire_open_event(void *opaque)
> void qemu_chr_generic_open(CharDriverState *s)
> {
> if (s->open_timer == NULL) {
> - s->open_timer = qemu_new_timer_ms(vm_clock,
> + s->open_timer = qemu_new_timer_ms(rt_clock,
> qemu_chr_fire_open_event, s);
> - qemu_mod_timer(s->open_timer, qemu_get_clock_ms(vm_clock) - 1);
> + qemu_mod_timer(s->open_timer, qemu_get_clock_ms(rt_clock) - 1);
> }
> }
>
> --
> 1.7.3.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer
2012-11-22 17:30 [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer Jan Kiszka
2012-11-23 11:49 ` [Qemu-devel] for-1.3: " Luiz Capitulino
2012-11-24 21:03 ` [Qemu-devel] " Blue Swirl
@ 2012-11-26 21:48 ` Anthony Liguori
2 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2012-11-26 21:48 UTC (permalink / raw)
To: Jan Kiszka, qemu-devel; +Cc: Paolo Bonzini, Dietmar Maurer, Luiz Capitulino
Jan Kiszka <jan.kiszka@siemens.com> writes:
> The vm clock may be stopped, and then we won't get open events anymore.
> Seen with QMP sessions.
>
> Reported-by: Dietmar Maurer <dietmar@proxmox.com>
> Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-char.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 88f4025..242b799 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -134,9 +134,9 @@ static void qemu_chr_fire_open_event(void *opaque)
> void qemu_chr_generic_open(CharDriverState *s)
> {
> if (s->open_timer == NULL) {
> - s->open_timer = qemu_new_timer_ms(vm_clock,
> + s->open_timer = qemu_new_timer_ms(rt_clock,
> qemu_chr_fire_open_event, s);
> - qemu_mod_timer(s->open_timer, qemu_get_clock_ms(vm_clock) - 1);
> + qemu_mod_timer(s->open_timer, qemu_get_clock_ms(rt_clock) - 1);
> }
> }
>
> --
> 1.7.3.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-26 21:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-22 17:30 [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer Jan Kiszka
2012-11-23 11:49 ` [Qemu-devel] for-1.3: " Luiz Capitulino
2012-11-24 21:03 ` [Qemu-devel] " Blue Swirl
2012-11-26 21:48 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).