From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TbsRC-0006Li-5b
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 07:32:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TbsR8-0002rW-6u
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 07:32:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56079)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TbsR7-0002rR-VQ
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 07:32:50 -0500
Date: Fri, 23 Nov 2012 13:32:43 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20121123123243.GB29800@stefanha-thinkpad.redhat.com>
References: <1353595852-30776-1-git-send-email-fred.konrad@greensocs.com>
	<1353595852-30776-4-git-send-email-fred.konrad@greensocs.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1353595852-30776-4-git-send-email-fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2 3/3] virtio-blk : add the virtio-blk
	device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, afaerber@suse.de

On Thu, Nov 22, 2012 at 03:50:52PM +0100, fred.konrad@greensocs.com wrote:
> @@ -656,3 +658,83 @@ void virtio_blk_exit(VirtIODevice *vdev)
>      blockdev_mark_auto_del(s->bs);
>      virtio_cleanup(vdev);
>  }
> +
> +static int virtio_blk_qdev_init(DeviceState *qdev)
> +{
> +    VirtIOBLKState *s = VIRTIO_BLK(qdev);

Please use "Block" or "Blk", not "BLK".