From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbtVo-0003rY-Cy for qemu-devel@nongnu.org; Fri, 23 Nov 2012 08:41:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbtVi-0002D0-Jt for qemu-devel@nongnu.org; Fri, 23 Nov 2012 08:41:44 -0500 Date: Fri, 23 Nov 2012 15:44:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20121123134414.GA9153@redhat.com> References: <20121121123600.GV18362@truffula.fritz.box> <20121121131339.GA5730@redhat.com> <20121121132157.GW18362@truffula.fritz.box> <50ACD6AC.6030001@suse.de> <20121121152737.GC5730@redhat.com> <20121122022718.GY18362@truffula.fritz.box> <20121122072303.GA23260@redhat.com> <20121123041307.GD5588@truffula.fritz.box> <20121123105323.GB7051@redhat.com> <20121123125951.GC4071@truffula.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121123125951.GC4071@truffula.fritz.box> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: "qemu-ppc@nongnu.org List" , qemu-devel qemu-devel On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote: > > Look, even if solution using a required property is less elegant for CLI > > use, it will work, won't it? > > So how about we merge it so that things work, and then we can discuss a > > patch on top that auto-generates this property? > > Well, there you have a point. And actually I've realised there are > other things we need to assign uniquely for each PHB and don't yet (IO > window addresses). So I need to look at a wider rework of this, which > I'll start on next week. Fine. Basically my point is it's typically a mistake to make some userspace visible parameter depend on order of initialization of devices in qemu. I don't insist on making users fully specify such parameters but it is one way to do this. > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson