From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TctUo-0008Nb-Cj for qemu-devel@nongnu.org; Mon, 26 Nov 2012 02:52:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TctUn-0002b1-8a for qemu-devel@nongnu.org; Mon, 26 Nov 2012 02:52:50 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:50280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TctUm-0002al-Vj for qemu-devel@nongnu.org; Mon, 26 Nov 2012 02:52:49 -0500 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Nov 2012 07:52:47 -0000 Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAQ7qage50331654 for ; Mon, 26 Nov 2012 07:52:36 GMT Received: from d06av11.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAQ7qhcd002048 for ; Mon, 26 Nov 2012 00:52:44 -0700 Date: Fri, 23 Nov 2012 15:52:01 +0100 From: Jens Freimann Message-ID: <20121123145201.GB28189@chuck.boeblingen.de.ibm.com> References: <1353665892-35445-1-git-send-email-jfrei@linux.vnet.ibm.com> <1353665892-35445-3-git-send-email-jfrei@linux.vnet.ibm.com> <50AF88F0.5020209@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50AF88F0.5020209@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Heinz Graalfs , qemu-devel , Alexander Graf , Viktor Mihajlovski , Cornelia Huck , Einar Lueck On Fri, Nov 23, 2012 at 03:32:16PM +0100, Christian Borntraeger wrote: > On 23/11/12 14:40, Alexander Graf wrote: > > > > On 23.11.2012, at 11:18, Jens Freimann wrote: > > > >> When resetting vcpus on s390/kvm we have to clear registers, psw > >> and prefix as described in the z/Architecture PoP, otherwise a > >> reboot won't work. IPL PSW and prefix are set later on by the > >> s390-ipl device reset code. > >> > >> Signed-off-by: Jens Freimann > >> --- > >> target-s390x/kvm.c | 26 +++++++++++++++++++++++++- > >> 1 file changed, 25 insertions(+), 1 deletion(-) > >> > >> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c > >> index 94de764..b1b791e 100644 > >> --- a/target-s390x/kvm.c > >> +++ b/target-s390x/kvm.c > > > > This needs to go into generic vcpu reset code. > > The kvm ioctl certainly not, no? (definitely necessary for kernels > without sync regs). > > I guess you are talking about moving the register initialisation > into s390_cpu_reset (target-s390x/cpu.c). Right? Jens can you have > a look? Yes, I'm already looking into it. s390_cpu_reset() is only called when booting the first time however because it's not registered as a reset handler. Trying to find out how if I can convert it to a qemu reset handler or if I have to do some QOM magic. Jens > Christian > -- Mit freundlichen Grüßen / Kind regards Jens Freimann -- IBM Linux Technology Center / Boeblingen lab IBM Systems &Technology Group, Systems Software Development ------------------------------------------------------------- IBM Deutschland Schoenaicher Str 220 71032 Boeblingen Phone: +49-7031-16 x1122 E-Mail: jfrei@de.ibm.com ------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294