From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Td0eG-0007Hv-L5
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 10:31:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Td0eA-0003fj-SJ
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 10:31:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Td0eA-0003fb-KR
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 10:30:58 -0500
Date: Mon, 26 Nov 2012 16:30:41 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121126163041.73ae74f0@thinkpad.mammed.net>
In-Reply-To: <1352948807-30415-10-git-send-email-afaerber@suse.de>
References: <1352948807-30415-1-git-send-email-afaerber@suse.de>
	<1352948807-30415-10-git-send-email-afaerber@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 09/11] target-i386/cpu: Name new CPUID bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: Boris Ostrovsky <boris.ostrovsky@amd.com>, Andre Przywara <osp@andrep.de>, qemu-devel@nongnu.org, anthony@codemonkey.ws, Eduardo Habkost <ehabkost@redhat.com>

Eduardo,

While doing rebase of x86 cpu properties on top of the current master, I've
stumbled on possibly removed by mistake cpuid feature, pls see inline

On Thu, 15 Nov 2012 04:06:45 +0100
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

...
> @@ -87,10 +87,10 @@ static const char *ext3_feature_name[] =3D {
>      "lahf_lm" /* AMD LahfSahf */, "cmp_legacy", "svm", "extapic" /* AMD =
ExtApicSpace */,
>      "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
>      "3dnowprefetch", "osvw", "ibs", "xop",
> -    "skinit", "wdt", NULL, NULL,
> -    "fma4", NULL, "cvt16", "nodeid_msr",
                      ^^^^
> -    NULL, NULL, NULL, NULL,
> -    NULL, NULL, NULL, NULL,
> +    "skinit", "wdt", NULL, "lwp",
> +    "fma4", "tce", NULL, "nodeid_msr",
                      ^^^^  should we keep cvt16 here ?
> +    NULL, "tbm", "topoext", "perfctr_core",
> +    "perfctr_nb", NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>  };
...

it's committed as: c8acc380: target-i386/cpu: Name new CPUID bits

--=20
Regards,
  Igor