From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdS31-0000xJ-QR for qemu-devel@nongnu.org; Tue, 27 Nov 2012 15:46:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdS2u-0000CN-5c for qemu-devel@nongnu.org; Tue, 27 Nov 2012 15:46:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdS2t-0000Bs-U4 for qemu-devel@nongnu.org; Tue, 27 Nov 2012 15:46:20 -0500 Date: Tue, 27 Nov 2012 15:46:04 -0500 From: Jason Baron Message-ID: <20121127204604.GE2425@redhat.com> References: <0bc7997d87e325be985811d2627c339f7fc2b961.1348052498.git.julien.grall@citrix.com> <50B404E8.6070102@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <50B404E8.6070102@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Stefano.Stabellini@eu.citrix.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, Julien Grall , kraxel@redhat.com, avi@redhat.com On Tue, Nov 27, 2012 at 01:10:16AM +0100, Andreas F=E4rber wrote: > Am 19.09.2012 13:50, schrieb Julien Grall: > > This patch replaces all register_ioport* by a MemorySection. > > It permits to use the new Memory stuff like listener. > >=20 > > Moreover, the PCI is added as an argument for apm_init, so we > > can register IO inside the pci IO address space. > >=20 > > Signed-off-by: Julien Grall >=20 > Following today's q35 merge I needed the following diff to fix the buil= d: >=20 > diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c > index 2fc83a4..7de5427 100644 > --- a/hw/lpc_ich9.c > +++ b/hw/lpc_ich9.c > @@ -472,7 +472,7 @@ static int ich9_lpc_initfn(PCIDevice *d) > lpc->isa_bus =3D isa_bus; >=20 > ich9_cc_init(lpc); > - apm_init(&lpc->apm, ich9_apm_ctrl_changed, lpc); > + apm_init(d, &lpc->apm, ich9_apm_ctrl_changed, lpc); > return 0; > } >=20 > Julien/Jason, can you please verify that this is the correct device to = pass? >=20 Looks correct to me. Thanks, -Jason