From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TdSBQ-0002eJ-AV
	for qemu-devel@nongnu.org; Tue, 27 Nov 2012 15:55:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TdSBO-00032z-Vv
	for qemu-devel@nongnu.org; Tue, 27 Nov 2012 15:55:08 -0500
Received: from mail-ia0-f173.google.com ([209.85.210.173]:41332)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TdSBO-00032O-R0
	for qemu-devel@nongnu.org; Tue, 27 Nov 2012 15:55:06 -0500
Received: by mail-ia0-f173.google.com with SMTP id w21so7703949iac.4
	for <qemu-devel@nongnu.org>; Tue, 27 Nov 2012 12:55:05 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Date: Tue, 27 Nov 2012 14:54:30 -0600
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20121127205430.GA7962@vm>
References: <1354047085-12401-1-git-send-email-brogers@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1354047085-12401-1-git-send-email-brogers@suse.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter
	type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bruce Rogers <brogers@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, Nov 27, 2012 at 01:11:25PM -0700, Bruce Rogers wrote:
> The second parameter to qapi_dealloc_type_size should be a uint64_t *,
> not a size_t *. This was causing our 32 bit x86 build to fail, since
> warnings are treated as errors.
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>

Doh, I should've caught this in review. Yes, qapi's type generator uses
uint64_t as the underlying type for 'size', and the visitor interface
calls for uint64_t*, so that's what the implementation should use.

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  qapi/qapi-dealloc-visitor.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
> index a07b171..75214e7 100644
> --- a/qapi/qapi-dealloc-visitor.c
> +++ b/qapi/qapi-dealloc-visitor.c
> @@ -132,7 +132,7 @@ static void qapi_dealloc_type_number(Visitor *v, double *obj, const char *name,
>  {
>  }
> 
> -static void qapi_dealloc_type_size(Visitor *v, size_t *obj, const char *name,
> +static void qapi_dealloc_type_size(Visitor *v, uint64_t *obj, const char *name,
>                                     Error **errp)
>  {
>  }
> -- 
> 1.7.7
>