From: mdroth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check
Date: Wed, 28 Nov 2012 11:02:37 -0600 [thread overview]
Message-ID: <20121128170237.GD8690@vm> (raw)
In-Reply-To: <1354021324-31561-3-git-send-email-lcapitulino@redhat.com>
On Tue, Nov 27, 2012 at 11:01:56AM -0200, Luiz Capitulino wrote:
> fclose() returns EOF on error.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index a2216f2..c284083 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -170,7 +170,7 @@ void qmp_guest_file_close(int64_t handle, Error **err)
> }
>
> ret = fclose(gfh->fh);
> - if (ret == -1) {
> + if (ret == EOF) {
> error_set(err, QERR_QGA_COMMAND_FAILED, "fclose() failed");
> return;
> }
> --
> 1.8.0
>
next prev parent reply other threads:[~2012-11-28 17:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 13:01 [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4) Luiz Capitulino
2012-11-27 13:01 ` [Qemu-devel] [PATCH 01/10] qemu-ga: guest_file_handle_find(): take an Error argument Luiz Capitulino
2012-11-28 17:01 ` mdroth
2012-11-27 13:01 ` [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check Luiz Capitulino
2012-11-28 17:02 ` mdroth [this message]
2012-11-27 13:01 ` [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting Luiz Capitulino
2012-11-28 17:54 ` mdroth
2012-11-28 19:31 ` Luiz Capitulino
2012-11-28 21:26 ` Eric Blake
2012-11-28 22:17 ` mdroth
2012-11-29 12:00 ` Luiz Capitulino
2012-11-27 13:01 ` [Qemu-devel] [PATCH 04/10] qemu-ga: qmp_guest_shutdown(): " Luiz Capitulino
2012-11-28 19:27 ` mdroth
2012-11-27 13:01 ` [Qemu-devel] [PATCH 05/10] qemu-ga: build_fs_mount_list(): take an Error argument Luiz Capitulino
2012-11-28 19:34 ` mdroth
2012-11-29 17:29 ` [Qemu-devel] [PATCH v2 " Luiz Capitulino
2012-11-27 13:02 ` [Qemu-devel] [PATCH 06/10] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set() Luiz Capitulino
2012-11-28 19:40 ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 07/10] qemu-ga: qmp_guest_fstrim(): " Luiz Capitulino
2012-11-28 19:41 ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 08/10] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() " Luiz Capitulino
2012-11-28 19:43 ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 09/10] qemu-ga: bios_supports_mode(): improve error reporting Luiz Capitulino
2012-11-28 19:48 ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 10/10] qemu-ga: guest_suspend(): " Luiz Capitulino
2012-11-28 19:49 ` mdroth
2012-11-28 20:04 ` [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4) mdroth
2012-11-28 20:12 ` mdroth
2012-12-12 1:03 ` Eric Blake
2012-11-30 18:22 ` mdroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128170237.GD8690@vm \
--to=mdroth@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).