From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47551)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1Tdnse-0006le-H8
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 15:05:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TdnsZ-000852-MU
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 15:05:12 -0500
Received: from mail-ie0-f173.google.com ([209.85.223.173]:59777)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TdnsZ-00084g-I9
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 15:05:07 -0500
Received: by mail-ie0-f173.google.com with SMTP id e13so10170925iej.4
	for <qemu-devel@nongnu.org>; Wed, 28 Nov 2012 12:05:06 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 28 Nov 2012 14:04:31 -0600
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20121128200431.GM8690@vm>
References: <1354021324-31561-1-git-send-email-lcapitulino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1354021324-31561-1-git-send-email-lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for
	1.4)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote:
> This series revamps qemu-ga error messages by:
> 
>  - Propagating errors down to functions that generate errors
>  - Fixing UndefinedErrors
>  - Getting rid of sprint() + error_set()
>  - Other small fixes

Hi Luiz,

Patches look good other than a few comments on usage of possibly-unset errno.

CC'ing Eric as a heads up, but based on previous comments (libvirt
always using 'desc' field over 'class' field and reporting it directly
to users) I don't think it should cause any compatibility issues on that
end.

> 
> Only the POSIX port is covered in this series, win32 is left to another day.
> 
> Luiz Capitulino (10):
>   qemu-ga: guest_file_handle_find(): take an Error argument
>   qemu-ga: qmp_guest_file_close(): fix fclose() error check
>   qemu-ga: qmp_guest_file_*: improve error reporting
>   qemu-ga: qmp_guest_shutdown(): improve error reporting
>   qemu-ga: build_fs_mount_list(): take an Error argument
>   qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()
>   qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()
>   qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() +
>     error_set()
>   qemu-ga: bios_supports_mode(): improve error reporting
>   qemu-ga: guest_suspend(): improve error reporting
> 
>  qga/commands-posix.c | 244 ++++++++++++++++++++++++++++-----------------------
>  1 file changed, 134 insertions(+), 110 deletions(-)
> 
> -- 
> 1.8.0
>