From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te4lO-0007VZ-10 for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:06:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Te4lH-0004xW-N2 for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:06:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te4lH-0004x4-FH for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:06:43 -0500 Date: Thu, 29 Nov 2012 16:09:28 +0200 From: "Michael S. Tsirkin" Message-ID: <20121129140928.GF9625@redhat.com> References: <1353597412-12232-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Anthony Liguori , qemu-devel , Blue Swirl , Khoa Huynh , Stefan Hajnoczi , Paolo Bonzini , Asias He On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > Michael, Paolo: Are you happy with v4? Looks pretty clean by itself. I sent some comments but they can be addressed later. What worries me most is the code duplication with regular virtio. I see two ways to reduce the maintainance somewhat - split out ring handling code in virtio-blk to a separate file to make it more obvious which part is inactive when data plane runs. - share ring processing code with virtio/virtio-blk (e.g. use callbacks) Was any thought given to implementing one of these two approaches? -- MST