From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te4rn-0002jr-Bn for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:13:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Te4ri-0007Mo-Lk for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:13:27 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:38585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te4ri-0007Mf-EX for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:13:22 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so8564030eek.4 for ; Thu, 29 Nov 2012 06:13:21 -0800 (PST) Date: Thu, 29 Nov 2012 15:13:17 +0100 From: Stefan Hajnoczi Message-ID: <20121129141317.GB13694@stefanha-thinkpad.redhat.com> References: <1354004184-15543-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1354004184-15543-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1.3] virtio-rng: do not use g_assert_cmpint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Tue, Nov 27, 2012 at 09:16:24AM +0100, Paolo Bonzini wrote: > g_assert_cmpint is not available on glib 2.12, which is the minimum > version required to build QEMU (we only require 2.16 to run tests, > since that is the first version including GTester). Do not use it > in hardware models, use a normal assertion instead. > > This fixes the buildbot failure for default_x86_64_rhel5. > > Signed-off-by: Paolo Bonzini > --- > hw/virtio-rng.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi