From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Auld, Will" <will.auld@intel.com>
Cc: "Liu, Jinsong" <jinsong.liu@intel.com>, Gleb <gleb@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Dugger, Donald D" <donald.d.dugger@intel.com>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support
Date: Thu, 29 Nov 2012 18:43:51 -0200 [thread overview]
Message-ID: <20121129204350.GC27255@amt.cnet> (raw)
In-Reply-To: <96EC5A4F3149B74492D2D9B9B1602C2728BB05FE@ORSMSX108.amr.corp.intel.com>
On Thu, Nov 29, 2012 at 07:21:28PM +0000, Auld, Will wrote:
> Marcelo,
>
> The behavior on reset is to return the TSC_AJUST msr value to 0x0. I am currently initializing this emulated msr in kvm_arch_vcpu_init().
Will,
Reset is handled by QEMU. kvm_arch_vcpu_init is only called during vcpu
allocation (ie vm creation). See x86_cpu_reset in QEMU's
target-i386/cpu.c file.
>
> >- Behaviour on reset: what is the behaviour on RESET?
>
> I am testing the rebase now. I would like to get any needed changes for this initialization into my next patch set version (v6) if possible.
For the kernel patch, everything is fine. Apparently for the QEMU patch
it is necessary to set value to zero on reset.
next prev parent reply other threads:[~2012-11-29 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 19:09 [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support Will Auld
2012-11-28 1:00 ` Marcelo Tosatti
2012-11-28 2:29 ` Auld, Will
2012-11-28 2:39 ` Amos Kong
2012-11-28 21:41 ` Auld, Will
2012-11-29 19:21 ` Auld, Will
2012-11-29 20:43 ` Marcelo Tosatti [this message]
2012-11-30 0:21 ` Auld, Will
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129204350.GC27255@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=donald.d.dugger@intel.com \
--cc=gleb@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=will.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).