From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeAxk-0000DF-DH for qemu-devel@nongnu.org; Thu, 29 Nov 2012 15:44:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeAxj-0005ka-Dp for qemu-devel@nongnu.org; Thu, 29 Nov 2012 15:44:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeAxj-0005kS-5t for qemu-devel@nongnu.org; Thu, 29 Nov 2012 15:43:59 -0500 Date: Thu, 29 Nov 2012 18:43:51 -0200 From: Marcelo Tosatti Message-ID: <20121129204350.GC27255@amt.cnet> References: <1354043340.4613.6.camel@WillAuldHomeLinux> <20121128010017.GG8295@amt.cnet> <96EC5A4F3149B74492D2D9B9B1602C2728BB05FE@ORSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96EC5A4F3149B74492D2D9B9B1602C2728BB05FE@ORSMSX108.amr.corp.intel.com> Subject: Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Auld, Will" Cc: "Liu, Jinsong" , Gleb , "kvm@vger.kernel.org" , qemu-devel , "Dugger, Donald D" , "avi@redhat.com" On Thu, Nov 29, 2012 at 07:21:28PM +0000, Auld, Will wrote: > Marcelo, > > The behavior on reset is to return the TSC_AJUST msr value to 0x0. I am currently initializing this emulated msr in kvm_arch_vcpu_init(). Will, Reset is handled by QEMU. kvm_arch_vcpu_init is only called during vcpu allocation (ie vm creation). See x86_cpu_reset in QEMU's target-i386/cpu.c file. > > >- Behaviour on reset: what is the behaviour on RESET? > > I am testing the rebase now. I would like to get any needed changes for this initialization into my next patch set version (v6) if possible. For the kernel patch, everything is fine. Apparently for the QEMU patch it is necessary to set value to zero on reset.