From: Luiz Capitulino <lcapitulino@redhat.com>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw
Date: Fri, 30 Nov 2012 09:42:19 -0200 [thread overview]
Message-ID: <20121130094219.70a862cd@doriath.home> (raw)
In-Reply-To: <20121130062557.26960.93209.stgit@melchior2.sdl.hitachi.co.jp>
On Fri, 30 Nov 2012 15:25:57 +0900
Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> wrote:
> Hi,
>
> This is version 5 of the qemu-ga fsfreeze hook patchset.
This series split is not good. You should squash patches 3/3 and 1/3 and
rebase this series on top of:
http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03016.html
Also, please look at qmp_shutdown() and bios_supports_mode() for examples
of command execution with improved error reporting.
> *Changes from v4: ( http://patchwork.ozlabs.org/patch/200924/ )
> 1/3: Improve error messages when fsfreeze hook is not executable.
> Make fsfreeze-hook disabled by default, and enabled only if
> --fsfreeze-hook option is specified.
Let me clarify that there are two ways of doing this. One is the way above,
the other way is to enable it by default but allow something like
"--fsfreeze-hook no" to disable the hook execution.
Both ways are fine with me.
next prev parent reply other threads:[~2012-11-30 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 6:25 [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw Tomoki Sekiyama
2012-11-30 6:26 ` [Qemu-devel] [PATCH v5 1/3] qemu-ga: execute " Tomoki Sekiyama
2012-11-30 6:26 ` [Qemu-devel] [PATCH v5 2/3] qemu-ga: sample fsfreeze hooks Tomoki Sekiyama
2012-11-30 6:26 ` [Qemu-devel] [PATCH v5 3/3] [for 1.4] qemu-ga: Improve error reporting in execute_fsfreeze_hook() Tomoki Sekiyama
2012-11-30 11:42 ` Luiz Capitulino [this message]
2012-11-30 12:40 ` [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw Tomoki Sekiyama
2012-11-30 12:51 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130094219.70a862cd@doriath.home \
--to=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=tomoki.sekiyama.qu@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).