From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TeOzG-0003lx-D5
	for qemu-devel@nongnu.org; Fri, 30 Nov 2012 06:42:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TeOzC-0007E6-4B
	for qemu-devel@nongnu.org; Fri, 30 Nov 2012 06:42:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TeOzB-0007Du-SX
	for qemu-devel@nongnu.org; Fri, 30 Nov 2012 06:42:26 -0500
Date: Fri, 30 Nov 2012 09:42:19 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121130094219.70a862cd@doriath.home>
In-Reply-To: <20121130062557.26960.93209.stgit@melchior2.sdl.hitachi.co.jp>
References: <20121130062557.26960.93209.stgit@melchior2.sdl.hitachi.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the
 guest on fsfreeze-freeze/thaw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Fri, 30 Nov 2012 15:25:57 +0900
Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> wrote:

> Hi,
> 
> This is version 5 of the qemu-ga fsfreeze hook patchset.

This series split is not good. You should squash patches 3/3 and 1/3 and
rebase this series on top of:

 http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03016.html

Also, please look at qmp_shutdown() and bios_supports_mode() for examples
of command execution with improved error reporting.

> *Changes from v4: ( http://patchwork.ozlabs.org/patch/200924/ )
>  1/3: Improve error messages when fsfreeze hook is not executable.
>       Make fsfreeze-hook disabled by default, and enabled only if
>       --fsfreeze-hook option is specified.

Let me clarify that there are two ways of doing this. One is the way above,
the other way is to enable it by default but allow something like
"--fsfreeze-hook no" to disable the hook execution.

Both ways are fine with me.