From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeVGy-0003qw-05 for qemu-devel@nongnu.org; Fri, 30 Nov 2012 13:25:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeVGw-00043m-8a for qemu-devel@nongnu.org; Fri, 30 Nov 2012 13:25:11 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:59580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeVGw-00043H-3s for qemu-devel@nongnu.org; Fri, 30 Nov 2012 13:25:10 -0500 Received: by mail-ie0-f173.google.com with SMTP id e13so1030436iej.4 for ; Fri, 30 Nov 2012 10:25:09 -0800 (PST) Sender: fluxion Date: Fri, 30 Nov 2012 12:22:08 -0600 From: mdroth Message-ID: <20121130182208.GP8690@vm> References: <1354021324-31561-1-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1354021324-31561-1-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote: > This series revamps qemu-ga error messages by: > > - Propagating errors down to functions that generate errors > - Fixing UndefinedErrors > - Getting rid of sprint() + error_set() > - Other small fixes > > Only the POSIX port is covered in this series, win32 is left to another day. Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga with a small formatting fix for 01/10 > > Luiz Capitulino (10): > qemu-ga: guest_file_handle_find(): take an Error argument > qemu-ga: qmp_guest_file_close(): fix fclose() error check > qemu-ga: qmp_guest_file_*: improve error reporting > qemu-ga: qmp_guest_shutdown(): improve error reporting > qemu-ga: build_fs_mount_list(): take an Error argument > qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set() > qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set() > qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + > error_set() > qemu-ga: bios_supports_mode(): improve error reporting > qemu-ga: guest_suspend(): improve error reporting > > qga/commands-posix.c | 244 ++++++++++++++++++++++++++++----------------------- > 1 file changed, 134 insertions(+), 110 deletions(-) > > -- > 1.8.0 >