From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf6tF-0004Qh-T0 for qemu-devel@nongnu.org; Sun, 02 Dec 2012 05:35:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tf6tE-0001fu-GX for qemu-devel@nongnu.org; Sun, 02 Dec 2012 05:35:13 -0500 Received: from mail-bk0-f45.google.com ([209.85.214.45]:52823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf6tE-0001fq-8x for qemu-devel@nongnu.org; Sun, 02 Dec 2012 05:35:12 -0500 Received: by mail-bk0-f45.google.com with SMTP id jk13so632460bkc.4 for ; Sun, 02 Dec 2012 02:35:11 -0800 (PST) Date: Sun, 2 Dec 2012 18:34:53 +0800 From: walimis Message-ID: <20121202103453.GA6029@pek-lwang0-d1> References: <1354417042-8818-1-git-send-email-andreas.faerber@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1354417042-8818-1-git-send-email-andreas.faerber@web.de> Subject: Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Peter Maydell , peter.crosthwaite@xilinx.com, Igor Mitsyanko , qemu-devel@nongnu.org, kraxel@redhat.com, Vincent Palatin On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas Färber wrote: >Hello, > >Some review comments for SysBus EHCI were ignored in favor of merging into 1.3. >As requested by Gerd, this now follows up with the cleanups I had requested >from Peter C. Apart from using the new-style QOM casts it also achieves some >deduplification. It then goes on to implement the suggested more slim way to >have different capsbase and opregbase values; the alternative would be to >create a new struct SysBusEHCIInfo for declarative initialization. Given that >there are only few models for now, the imperative approach allows for more >flexibility such as inheritence when, e.g., an Exynos 5 model varies only >slightly from Exynos 4. > >Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a >new patch of mine to prepare a Tegra 2 EHCI device (cf. my tegra branch) to BTW, where can I find your tegra branch? >show how this works out. > >Regards, >Andreas > >Changes from Liming Wang's patchset: >* Introduce abstract sysbus-ehci-usb and pci-ehci-usb types It's good to implement these two abstract types, so that it's easy to add sysbus-ehci-usb sub types. >* Move class_init / instance_init to base type as far as possible >* Use TYPE_* constant for instantiating exynos4210 EHCI >* Added my tegra2 SysBus EHCI device to the mix > >Cc: Gerd Hoffmann >Cc: Peter A. G. Crosthwaite >Cc: Peter Maydell >Cc: Igor Mitsyanko >Cc: Liming Wang >Cc: Vincent Palatin > >Andreas Färber (4): > usb/ehci: Clean up SysBus and PCI EHCI split > usb/ehci: Move capsbase and opregbase into SysBus EHCI class > usb/ehci: Add SysBus EHCI device for Exynos4210 > usb/ehci: Add Tegra2 SysBus EHCI device > >Liming Wang (1): > exynos4210: Add EHCI support The test is OK for exynos4210 ehci. Regards, Liming Wang > > hw/exynos4210.c | 7 +++++ > hw/exynos4210_gic.c | 2 +- > hw/usb/hcd-ehci-pci.c | 37 ++++++++++++++++------ > hw/usb/hcd-ehci-sysbus.c | 76 ++++++++++++++++++++++++++++++++++++++++++---- > hw/usb/hcd-ehci.h | 2 ++ > 5 Dateien geändert, 108 Zeilen hinzugefügt(+), 16 Zeilen entfernt(-) > >-- >1.7.10.4 >