From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfETC-00054D-Rm for qemu-devel@nongnu.org; Sun, 02 Dec 2012 13:40:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfETB-0006x0-Js for qemu-devel@nongnu.org; Sun, 02 Dec 2012 13:40:50 -0500 Received: from indium.canonical.com ([91.189.90.7]:52185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfETB-0006wm-Cw for qemu-devel@nongnu.org; Sun, 02 Dec 2012 13:40:49 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1TfETA-0005Su-4K for ; Sun, 02 Dec 2012 18:40:48 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 170222E807B for ; Sun, 2 Dec 2012 18:40:48 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Sun, 02 Dec 2012 18:31:03 -0000 From: Peter Maydell Sender: bounces@canonical.com References: <20121202161653.4416.21917.malonedeb@wampee.canonical.com> Message-Id: <20121202183104.4328.37653.malone@wampee.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1085658] Re: exec, cpu log Reply-To: Bug 1085658 <1085658@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > CPU_LOG_EXEC (and CPU_LOG_TB_CPU) does not work (i.e. not of each tb dumped) because tb links is occur. This is true, but I'm afraid I don't think this patch is the right approach. Enabling debug tracing shouldn't cause us to change behaviour, so we can't just disable TB linking when doing debug logging. -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1085658 Title: exec, cpu log Status in QEMU: New Bug description: Hello! CPU_LOG_EXEC (and CPU_LOG_TB_CPU) does not work (i.e. not of each tb dump= ed) because tb links is occur. Patch: diff --git a/cpu-exec.c b/cpu-exec.c index 904ee73..509d50c 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -582,7 +582,11 @@ int cpu_exec(CPUArchState *env) /* see if we can patch the calling TB. When the TB spans two pages, we cannot safely do a direct jump. */ - if (next_tb !=3D 0 && tb->page_addr[1] =3D=3D -1) { + if (next_tb !=3D 0 && tb->page_addr[1] =3D=3D -1 +#ifdef CONFIG_DEBUG_EXEC + && !qemu_loglevel_mask(CPU_LOG_EXEC | CPU_LOG_TB_CPU) +#endif + ) { tb_add_jump((TranslationBlock *)(next_tb & ~3), next= _tb & 3, tb); } spin_unlock(&tb_lock); To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1085658/+subscriptions