From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfVim-0007rX-5Z for qemu-devel@nongnu.org; Mon, 03 Dec 2012 08:06:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfVig-0003mO-Dq for qemu-devel@nongnu.org; Mon, 03 Dec 2012 08:06:04 -0500 Date: Mon, 3 Dec 2012 14:05:53 +0100 From: Stefan Hajnoczi Message-ID: <20121203130553.GG6048@stefanha-thinkpad.redhat.com> References: <1353694338-13162-1-git-send-email-armbru@redhat.com> <1353694338-13162-2-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1353694338-13162-2-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, jordan.l.justen@intel.com, qemu-devel@nongnu.org On Fri, Nov 23, 2012 at 07:12:17PM +0100, Markus Armbruster wrote: > diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c > index 9d7c5f4..066c4fe 100644 > --- a/hw/pc_sysfw.c > +++ b/hw/pc_sysfw.c > @@ -84,6 +84,11 @@ static void pc_fw_add_pflash_drv(void) > bios_name = BIOS_FILENAME; > } > filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); > + if (!filename) { > + error_report("Can't open BIOS image %s: %s", > + bios_name, strerror(errno)); qemu_find_file() does not document that errno is set when returning NULL. I can't find other callers to qemu_find_file() that use errno either. Please add a doc comment to qemu_find_file() that errno will be set on NULL return, otherwise we can't rely on it in the caller. Stefan