From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, jordan.l.justen@intel.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path
Date: Mon, 3 Dec 2012 14:06:49 +0100 [thread overview]
Message-ID: <20121203130649.GH6048@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1353694338-13162-3-git-send-email-armbru@redhat.com>
On Fri, Nov 23, 2012 at 07:12:18PM +0100, Markus Armbruster wrote:
> Harmless, because we the error inevitably leads to another, fatal one
> in pc_system_flash_init(): PC system firmware (pflash) not available.
> Fix it anyway.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/pc_sysfw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
next prev parent reply other threads:[~2012-12-03 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 18:12 [Qemu-devel] [PATCH 0/2] pc_fw_add_pflash_drv() fixes Markus Armbruster
2012-11-23 18:12 ` [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure Markus Armbruster
2012-12-03 13:05 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-12-03 13:21 ` Markus Armbruster
2012-12-05 14:28 ` [Qemu-devel] [PATCH v2 " Markus Armbruster
2012-12-19 9:29 ` Stefan Hajnoczi
2012-11-23 18:12 ` [Qemu-devel] [PATCH 2/2] pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path Markus Armbruster
2012-12-03 13:06 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-16 11:41 [Qemu-devel] [PATCH 0/2] Fix two buggy pc_sysfw error paths Markus Armbruster
2012-08-16 11:41 ` [Qemu-devel] [PATCH 2/2] pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203130649.GH6048@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=jordan.l.justen@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).