From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TfbnI-0006Ix-9q
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 14:35:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TfbnG-0002eD-Fn
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 14:35:08 -0500
Sender: fluxion <flukshun@gmail.com>
Date: Mon, 3 Dec 2012 13:31:22 -0600
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20121203193122.GA26231@vm>
References: <1339086183-1356-1-git-send-email-afaerber@suse.de>
	<5058693B.9020103@msgid.tls.msk.ru> <505885F1.7000406@suse.de>
	<508B9C1C.2090702@msgid.tls.msk.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <508B9C1C.2090702@msgid.tls.msk.ru>
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH 1.3] make_device_config.sh:
 Fix target path in generated dependency file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Gerhard Wiesinger <lists@wiesinger.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Sat, Oct 27, 2012 at 12:32:28PM +0400, Michael Tokarev wrote:
> Ping?

Ping.

Fix still applicable for 1.3, also looking to pull it in for 1.2.2.

> 
> /mjt
> 
> On 18.09.2012 18:32, Andreas Färber wrote:
> > Am 18.09.2012 14:29, schrieb Michael Tokarev:
> >> Has it been applied to anything?  I don't think so.
> >> Is it still needed?
> > 
> > Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.
> > 
> > /-F
> > 
> >>
> >> Thanks,
> >>
> >> /mjt
> >>
> >> On 07.06.2012 20:23, Andreas Färber wrote:
> >>> config-devices.mak.d is included from Makefile.target, i.e. from inside
> >>> the *-softmmu/ directory. It included the directory path, so never
> >>> applied to the actual config-devices.mak. Symptoms were spurious
> >>> dependency issues with default-configs/pci.mak.
> >>>
> >>> Fix by using `basename` to strip the directory path.
> >>>
> >>> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> >>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> >>> ---
> >>>  Seems I forgot to send this out before 1.1...
> >>>
> >>>  scripts/make_device_config.sh |    2 +-
> >>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> >>> index 5d14885..0778fe2 100644
> >>> --- a/scripts/make_device_config.sh
> >>> +++ b/scripts/make_device_config.sh
> >>> @@ -25,4 +25,4 @@ done
> >>>  process_includes $src > $dest
> >>>  
> >>>  cat $src $all_includes | grep -v '^include' > $dest
> >>> -echo "$1: $all_includes" > $dep
> >>> +echo "`basename $1`: $all_includes" > $dep
> >>
> > 
> > 
> 
>