From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TfdY5-0000di-2h
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 16:27:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TfdXz-0004C2-4x
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 16:27:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17150)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TfdXy-0004Aq-RX
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 16:27:27 -0500
Date: Mon, 3 Dec 2012 22:20:03 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121203222003.4363c53c@thinkpad.mammed.net>
In-Reply-To: <1354303642-4283-6-git-send-email-ehabkost@redhat.com>
References: <1354303642-4283-1-git-send-email-ehabkost@redhat.com>
	<1354303642-4283-6-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 05/10] qdev: move reset handler list from
 vl.c to hw/reset.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>

On Fri, 30 Nov 2012 17:27:17 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> The core qdev code uses the reset handler list from vl.c, and
> currently *-user has some hacks to make CPU reset work.
> 
> This moves qemu_register_reset(), qemu_unregister_reset() and
> qemu_devices_reset() to a new file, hw/reset.c, that can be used by qdev
> and by *-user.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
[...]
> diff --git a/hw/reset.c b/hw/reset.c
> new file mode 100644
> index 0000000..5e34b80
> --- /dev/null
> +++ b/hw/reset.c
> @@ -0,0 +1,43 @@
> +#include "hw/reset.h"
> +#include "qlist.h"
missing #include <glib.h> for g_malloc/g_free

[...]
> diff --git a/xen-all.c b/xen-all.c
> index 046cc2a..7d2a79f 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -14,6 +14,7 @@
>  #include "hw/pc.h"
>  #include "hw/xen_common.h"
>  #include "hw/xen_backend.h"
> +#include "hw/reset.h"
>  #include "qmp-commands.h"
>  
>  #include "range.h"
> -- 
> 1.7.11.7
> 
> 
Since you are going not include reset.o in *-user:
although dedicated reset.c is nice to have perhaps you can drop reset.c /it's
not very related to this series topic/ altogether to minimize scope of review
and limit patch only to reset.h and qemu_register_reset(),
qemu_unregister_reset() and qemu_devices_reset() stubs for *-user.

-- 
Regards,
  Igor