From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfuAB-0008AP-HS for qemu-devel@nongnu.org; Tue, 04 Dec 2012 10:12:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfuA1-0002Y6-UD for qemu-devel@nongnu.org; Tue, 04 Dec 2012 10:11:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfuA1-0002Xy-M0 for qemu-devel@nongnu.org; Tue, 04 Dec 2012 10:11:49 -0500 Date: Tue, 4 Dec 2012 10:11:38 -0500 From: jbaron@redhat.com Message-ID: <20121204151136.GA11468@redhat.com> References: <50BDA8EB.5090402@redhat.com> <20121204144243.GB13356@hedwig.ini.cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121204144243.GB13356@hedwig.ini.cmu.edu> Subject: Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: rene@exactcode.com, jan.kiszka@siemens.com, agraf@suse.de, qemu-devel@nongnu.org, kraxel@redhat.com, anthony@codemonkey.ws On Tue, Dec 04, 2012 at 09:42:44AM -0500, Gabriel L. Somlo wrote: > On Tue, 04 Dec 2012 08:40:27 +0100 Gerd Hoffmann wrote: > >On Mon, 3 Dec 2012 13:47:04 -0500, Jason Baron wrote: > >> 2) HPET ACPI error > >> > >> This line: 'IRQNoFlags () {2, 8}' in the HPET acpi table is causing the > >> folloing ACPI message (removing it makes it go away): > > > > Hmm. That was added to make macos x happy and is also present on real > > hardware, so I'm wondering what is going on here. > > Without that line, OS X only works as a single-core, non-SMP guest. > This is the "legacy replacement irq mapping" option for HPET (section > 2.4.2, page 24 of the IA-PC HPET Specification). > > The options are 'IRQNoFlags () {2, 8}' for "APIC mapping" or > 'IRQNoFlags () {0, 8}' for "8259 mapping". Either one works for SMP + OS X. > > I don't have an XP install image anymore, but does replacing 2,8 with > 0,8 help ? > no. > On a few of my machines, this is actually coded as > > IRQNoFlags () > {0} /* or 2 */ > IRQNoFlags () > {8} > > Based on my reading of the ACPI manual, this should be syntactically > equivalent to the the comma-separated single-line format we're currently > using, but could it be that WinXP is picky about the specifics ? > Didn't seem to help either. I also tried having just a single irq from 0,2,8, and that didn't work either. The only thing that seems to make XP happy is completely removing that line. So I'm not sure what is wrong. > Also, as far as I can tell, this change never made it into the > "q35-acpi-dsdt.dsl" file, just the "classic" acpi-dsdt.dsl (or, lately, > acpi-dsdt-hpet.dsl). I was about to submit another patch for that, but > now I guess I won't press it until we sort this out :) > q35-acpi-dsdt.dsl is the current sebios tree does: #include "acpi-dsdt-hpet.dsl" Thanks, -Jason