From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TfyMF-0006bR-QF
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 14:40:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TfyME-0008J3-9M
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 14:40:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57879)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TfyMD-0008Iy-WE
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 14:40:42 -0500
Date: Tue, 4 Dec 2012 20:40:37 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121204204037.4f04365a@thinkpad.mammed.net>
In-Reply-To: <1354649683-9078-2-git-send-email-ehabkost@redhat.com>
References: <1354649683-9078-1-git-send-email-ehabkost@redhat.com>
	<1354649683-9078-2-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] target-i386/cpu.c: coding style fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Don Slutz <Don@CloudSwitch.Com>, qemu-devel@nongnu.org, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>

On Tue,  4 Dec 2012 17:34:38 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> - Use spaces instead of tabs on cpu_x86_cpuid().
> - Use braces on 'if' statement cpu_x86_find_by_name().
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 28 +++++++++++++++-------------
>  1 file changed, 15 insertions(+), 13 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index c6c2ca0..7afe839 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1227,9 +1227,11 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def, const char *cpu_model)
>      uint32_t minus_7_0_ebx_features = 0;
>      uint32_t numvalue;
>  
> -    for (def = x86_defs; def; def = def->next)
> -        if (name && !strcmp(name, def->name))
> +    for (def = x86_defs; def; def = def->next) {
> +        if (name && !strcmp(name, def->name)) {
>              break;
> +        }
> +    }
>      if (kvm_enabled() && name && strcmp(name, "host") == 0) {
>          kvm_cpu_fill_host(x86_cpu_def);
>      } else if (!def) {
> @@ -1835,17 +1837,17 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
>          }
>          break;
>      case 0x8000000A:
> -	if (env->cpuid_ext3_features & CPUID_EXT3_SVM) {
> -		*eax = 0x00000001; /* SVM Revision */
> -		*ebx = 0x00000010; /* nr of ASIDs */
> -		*ecx = 0;
> -		*edx = env->cpuid_svm_features; /* optional features */
> -	} else {
> -		*eax = 0;
> -		*ebx = 0;
> -		*ecx = 0;
> -		*edx = 0;
> -	}
> +        if (env->cpuid_ext3_features & CPUID_EXT3_SVM) {
> +            *eax = 0x00000001; /* SVM Revision */
> +            *ebx = 0x00000010; /* nr of ASIDs */
> +            *ecx = 0;
> +            *edx = env->cpuid_svm_features; /* optional features */
> +        } else {
> +            *eax = 0;
> +            *ebx = 0;
> +            *ecx = 0;
> +            *edx = 0;
> +        }
>          break;
>      case 0xC0000000:
>          *eax = env->cpuid_xlevel2;
> -- 
> 1.7.11.7
> 
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

-- 
Regards,
  Igor