From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41058)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TgWMX-0006nQ-TT
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 02:59:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TgWMR-0006Bb-Vu
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 02:59:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TgWMR-0006BG-OK
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 02:59:11 -0500
Date: Thu, 6 Dec 2012 10:02:21 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20121206080221.GC10837@redhat.com>
References: <87624iikcw.fsf@rustcorp.com.au> <87zk1uca8z.fsf@elfo.mitica>
	<87r4n5h0fx.fsf@rustcorp.com.au>
	<20121205110807.GA10045@redhat.com>
	<87obi7g1k5.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87obi7g1k5.fsf@rustcorp.com.au>
Subject: Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding
 buffers are flushed (was Re: vmstate conversion for virtio?)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: QEMU-devel <qemu-devel@nongnu.org>, quintela@redhat.com

On Thu, Dec 06, 2012 at 04:33:06PM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > Add sanity check to address the following concern:
> >
> > On Wed, Dec 05, 2012 at 09:47:22AM +1030, Rusty Russell wrote:
> >> All we need is the index of the request; the rest can be re-read from
> >> the ring.
> 
> The terminology I used here was loose, indeed.
> 
> We need the head of the chained descriptor, which we already read from
> the ring when we gathered the request.

So ack that patch?

> Currently we dump a massive structure; it's inelegant at the very least.
> 
> Cheers,
> Rusty.

Hmm not sure what you refer to. I see this per ring:

        qemu_put_be32(f, vdev->vq[i].vring.num);
        qemu_put_be64(f, vdev->vq[i].pa);
        qemu_put_be16s(f, &vdev->vq[i].last_avail_idx);

Looks like there's no way around savng these fields.

-- 
MST