From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TgjsX-0003fo-HU
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 17:25:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TgjsW-0007EX-9k
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 17:25:13 -0500
Received: from mail-ie0-f178.google.com ([209.85.223.178]:36719)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TgjsW-0007ER-4z
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 17:25:12 -0500
Received: by mail-ie0-f178.google.com with SMTP id c12so12673658ieb.37
	for <qemu-devel@nongnu.org>; Thu, 06 Dec 2012 14:25:11 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Date: Thu, 6 Dec 2012 16:24:43 -0600
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20121206222443.GC30686@vm>
References: <1354828325-16568-1-git-send-email-imammedo@redhat.com>
	<1354828325-16568-3-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1354828325-16568-3-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: use
 visit_type_unit_suffixed_int() to parse tsc_freq property value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, afaerber@suse.de

On Thu, Dec 06, 2012 at 10:12:05PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>   v2:
>    - replace visit_type_freq() with visit_type_unit_suffixed_int()
>      in x86_cpuid_set_tsc_freq()
> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index c6c2ca0..b7f0aba 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1195,7 +1195,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
>      const int64_t max = INT64_MAX;
>      int64_t value;
> 
> -    visit_type_int(v, &value, name, errp);
> +    visit_type_unit_suffixed_int(v, &value, name, 1000, errp);
>      if (error_is_set(errp)) {
>          return;
>      }
> -- 
> 1.7.11.7
>