From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th2fv-0006zm-Jr for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:29:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Th2fu-0004e6-DD for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:29:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th2fu-0004e1-3k for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:29:26 -0500 Date: Fri, 7 Dec 2012 16:29:20 -0200 From: Luiz Capitulino Message-ID: <20121207162920.732f40e6@doriath.home> In-Reply-To: <20121207174724.GE30686@vm> References: <20121207083922.10624.97583.stgit@melchior2.sdl.hitachi.co.jp> <20121207083932.10624.8173.stgit@melchior2.sdl.hitachi.co.jp> <20121207115516.5e363012@doriath.home> <20121207174724.GE30686@vm> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: Tomoki Sekiyama , qemu-devel@nongnu.org On Fri, 7 Dec 2012 11:47:24 -0600 mdroth wrote: > On Fri, Dec 07, 2012 at 11:55:16AM -0200, Luiz Capitulino wrote: > > On Fri, 07 Dec 2012 17:39:32 +0900 > > Tomoki Sekiyama wrote: > > > > > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > > > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > > > - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot > > > > > > Signed-off-by: Tomoki Sekiyama > > > --- > > > .gitignore | 1 > > > Makefile | 2 - > > > scripts/qemu-guest-agent/fsfreeze-hook | 33 ++++++++++++ > > > .../fsfreeze-hook.d/mysql-flush.sh.sample | 55 ++++++++++++++++++++ > > > 4 files changed, 90 insertions(+), 1 deletion(-) > > > create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook > > > create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample > > > > > > diff --git a/.gitignore b/.gitignore > > > index bd6ba1c..286822d 100644 > > > --- a/.gitignore > > > +++ b/.gitignore > > > @@ -93,3 +93,4 @@ cscope.* > > > tags > > > TAGS > > > *~ > > > +!scripts/qemu-guest-agent/fsfreeze-hook.d > > > > Why? Do we expect to have *~ files in there? > > I think default vim configurations will copy to ~ prior to > editing. But should that be tracked by git specifically in that dir? > > > diff --git a/Makefile b/Makefile > > > index 9ecbcbb..466dcd7 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -248,7 +248,7 @@ clean: > > > # avoid old build problems by removing potentially incorrect old files > > > rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h > > > rm -f qemu-options.def > > > - find . -name '*.[od]' -exec rm -f {} + > > > + find . -name '*.[od]' -type f -exec rm -f {} + > > > > What does this change have to do with this patch? > > Looks like it'll try (and fail, due to lack of -r option to rm) to > delete the fsfreeze-hook.d directory on `make clean`. For in-tree builds > at least. I can't see it, but well, I don't want to hold this patch for minor things either... It looks good for me apart from these two nitpicks.