From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Th2jT-0001nG-FN
	for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:33:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Th2jM-0005ji-VM
	for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:33:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59926)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Th2jM-0005jX-Kj
	for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:33:00 -0500
Date: Fri, 7 Dec 2012 16:31:13 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121207163113.2f238c8f@doriath.home>
In-Reply-To: <50C233FE.5020904@redhat.com>
References: <20121207083922.10624.97583.stgit@melchior2.sdl.hitachi.co.jp>
	<20121207083932.10624.8173.stgit@melchior2.sdl.hitachi.co.jp>
	<20121207115516.5e363012@doriath.home>
	<50C233FE.5020904@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Fri, 07 Dec 2012 11:22:54 -0700
Eric Blake <eblake@redhat.com> wrote:

> On 12/07/2012 06:55 AM, Luiz Capitulino wrote:
> > On Fri, 07 Dec 2012 17:39:32 +0900
> > Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> wrote:
> > 
> >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> >>   - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
> >>   - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot
> >>
> >> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
> >> ---
> >>  .gitignore                                         |    1 
> >>  Makefile                                           |    2 -
> >>  scripts/qemu-guest-agent/fsfreeze-hook             |   33 ++++++++++++
> >>  .../fsfreeze-hook.d/mysql-flush.sh.sample          |   55 ++++++++++++++++++++
> >>  4 files changed, 90 insertions(+), 1 deletion(-)
> >>  create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook
> >>  create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index bd6ba1c..286822d 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -93,3 +93,4 @@ cscope.*
> >>  tags
> >>  TAGS
> >>  *~
> >> +!scripts/qemu-guest-agent/fsfreeze-hook.d
> > 
> > Why? Do we expect to have *~ files in there?
> 
> What does your question have to do with the patch, which isn't even
> touching the pre-existing *~ line?

As far I could understand the ! prefix in gitignore documention, it's
changing the *~ meaning for the fsfreeze-hoo.d directory, and I wanted
to understand why.

> >> diff --git a/Makefile b/Makefile
> >> index 9ecbcbb..466dcd7 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -248,7 +248,7 @@ clean:
> >>  # avoid old build problems by removing potentially incorrect old files
> >>  	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
> >>  	rm -f qemu-options.def
> >> -	find . -name '*.[od]' -exec rm -f {} +
> >> +	find . -name '*.[od]' -type f -exec rm -f {} +
> > 
> > What does this change have to do with this patch?
> 
> Because this patch introduces a directory
> scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample that
> belongs to the repo and therefore must not be cleaned.