From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th37W-00034A-Fx for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:58:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Th37V-00047M-BK for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:57:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th37V-00047I-1n for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:57:57 -0500 Date: Fri, 7 Dec 2012 16:57:48 -0200 From: Luiz Capitulino Message-ID: <20121207165748.0bf3b55e@doriath.home> In-Reply-To: <50C23778.3020507@redhat.com> References: <20121207083922.10624.97583.stgit@melchior2.sdl.hitachi.co.jp> <20121207083932.10624.8173.stgit@melchior2.sdl.hitachi.co.jp> <20121207115516.5e363012@doriath.home> <50C233FE.5020904@redhat.com> <20121207163113.2f238c8f@doriath.home> <50C23778.3020507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Tomoki Sekiyama , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Fri, 07 Dec 2012 11:37:44 -0700 Eric Blake wrote: > On 12/07/2012 11:31 AM, Luiz Capitulino wrote: > >>>> +++ b/.gitignore > >>>> @@ -93,3 +93,4 @@ cscope.* > >>>> tags > >>>> TAGS > >>>> *~ > >>>> +!scripts/qemu-guest-agent/fsfreeze-hook.d > >>> > >>> Why? Do we expect to have *~ files in there? > >> > >> What does your question have to do with the patch, which isn't even > >> touching the pre-existing *~ line? > > > > As far I could understand the ! prefix in gitignore documention, it's > > changing the *~ meaning for the fsfreeze-hoo.d directory, and I wanted > > to understand why. > > > > No, it is changing a much earlier line: > > *.d > > to say that this _particular_ .d is allowed to be committed. It has > nothing to do with *~. Ah, now it makes a lot of sense, thanks Eric. It would be nice to move it right below *.d, to avoid stupid comments :) > Still, I have to wonder if we really want to store these files in a .d > in the repository itself, or if we should store them under some other > file name and only at 'make install' time insert them into a .d at the > install destination. It would clean up this confusion about the > .gitignore as well as the change to the 'find' command during 'make clean'. Well, now that I understand it both ways are fine with me (ie. what you suggest and what's been implemented in this patch).