qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: proper OpenGL/GLX probe
Date: Sun, 9 Dec 2012 23:21:31 +0100	[thread overview]
Message-ID: <201212092321.31172.michael@walle.cc> (raw)
In-Reply-To: <1354314252-9016-1-git-send-email-michael@walle.cc>

Am Freitag 30 November 2012, 23:24:11 schrieben Sie:
> Probe for GL and GLX symbols and X11 library. This fixes a build error
> where the header files are available but the libraries are not.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  configure |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure b/configure
> index 994f731..fedde51 100755
> --- a/configure
> +++ b/configure
> @@ -2323,14 +2323,14 @@ fi
>  ##########################################
>  # opengl probe, used by milkymist-tmu2
>  if test "$opengl" != "no" ; then
> -  opengl_libs="-lGL"
> +  opengl_libs="-lGL -lX11"
>    cat > $TMPC << EOF
>  #include <X11/Xlib.h>
>  #include <GL/gl.h>
>  #include <GL/glx.h>
> -int main(void) { return GL_VERSION != 0; }
> +int main(void) { glBegin(0); glXQueryVersion(0,0,0); return 0; }
>  EOF
> -  if compile_prog "" "-lGL" ; then
> +  if compile_prog "" "-lGL -lX11" ; then
>      opengl=yes
>    else
>      if test "$opengl" = "yes" ; then

ping, could anyone pick these? blue?

malc, can you ack these patches?

-- 
michael

      parent reply	other threads:[~2012-12-09 22:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30 22:24 [Qemu-devel] [PATCH 1/2] configure: proper OpenGL/GLX probe Michael Walle
2012-11-30 22:24 ` [Qemu-devel] [PATCH 2/2] configure: rename OpenGL feature to GLX Michael Walle
2012-12-09 22:21 ` Michael Walle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201212092321.31172.michael@walle.cc \
    --to=michael@walle.cc \
    --cc=av1474@comtv.ru \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).