From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1ThpFh-00067j-RH
	for qemu-devel@nongnu.org; Sun, 09 Dec 2012 17:21:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1ThpFg-00081W-Me
	for qemu-devel@nongnu.org; Sun, 09 Dec 2012 17:21:37 -0500
Received: from mail.serverraum.org ([78.47.150.89]:44409)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1ThpFg-00081J-GM
	for qemu-devel@nongnu.org; Sun, 09 Dec 2012 17:21:36 -0500
From: Michael Walle <michael@walle.cc>
Date: Sun, 9 Dec 2012 23:21:31 +0100
References: <1354314252-9016-1-git-send-email-michael@walle.cc>
In-Reply-To: <1354314252-9016-1-git-send-email-michael@walle.cc>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201212092321.31172.michael@walle.cc>
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: proper OpenGL/GLX probe
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, malc <av1474@comtv.ru>

Am Freitag 30 November 2012, 23:24:11 schrieben Sie:
> Probe for GL and GLX symbols and X11 library. This fixes a build error
> where the header files are available but the libraries are not.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  configure |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure b/configure
> index 994f731..fedde51 100755
> --- a/configure
> +++ b/configure
> @@ -2323,14 +2323,14 @@ fi
>  ##########################################
>  # opengl probe, used by milkymist-tmu2
>  if test "$opengl" != "no" ; then
> -  opengl_libs="-lGL"
> +  opengl_libs="-lGL -lX11"
>    cat > $TMPC << EOF
>  #include <X11/Xlib.h>
>  #include <GL/gl.h>
>  #include <GL/glx.h>
> -int main(void) { return GL_VERSION != 0; }
> +int main(void) { glBegin(0); glXQueryVersion(0,0,0); return 0; }
>  EOF
> -  if compile_prog "" "-lGL" ; then
> +  if compile_prog "" "-lGL -lX11" ; then
>      opengl=yes
>    else
>      if test "$opengl" = "yes" ; then

ping, could anyone pick these? blue?

malc, can you ack these patches?

-- 
michael