From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti2up-0005Lo-Md for qemu-devel@nongnu.org; Mon, 10 Dec 2012 07:57:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti2un-0000o2-0M for qemu-devel@nongnu.org; Mon, 10 Dec 2012 07:56:59 -0500 Date: Mon, 10 Dec 2012 15:00:05 +0200 From: "Michael S. Tsirkin" Message-ID: <20121210130005.GB28118@redhat.com> References: <1353996453-24262-1-git-send-email-david@gibson.dropbear.id.au> <1353996453-24262-2-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1353996453-24262-2-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH 1/2] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org On Tue, Nov 27, 2012 at 05:07:32PM +1100, David Gibson wrote: > The PAPR specification requires that every bus or device mediated by the > IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check > to enforce this, which will help catch errors in configuration earlier. > > Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin > --- > hw/spapr_iommu.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/spapr_iommu.c b/hw/spapr_iommu.c > index 02d78cc..3011b25 100644 > --- a/hw/spapr_iommu.c > +++ b/hw/spapr_iommu.c > @@ -120,6 +120,12 @@ DMAContext *spapr_tce_new_dma_context(uint32_t liobn, size_t window_size) > { > sPAPRTCETable *tcet; > > + if (spapr_tce_find_by_liobn(liobn)) { > + fprintf(stderr, "Attempted to create TCE table with duplicate" > + " LIOBN 0x%x\n", liobn); > + return NULL; > + } > + > if (!window_size) { > return NULL; > } > -- > 1.7.10.4