From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1Ti49w-0003Se-EF
	for qemu-devel@nongnu.org; Mon, 10 Dec 2012 09:16:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1Ti49p-0005ts-0f
	for qemu-devel@nongnu.org; Mon, 10 Dec 2012 09:16:40 -0500
Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:15593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1Ti49o-0005te-G4
	for qemu-devel@nongnu.org; Mon, 10 Dec 2012 09:16:32 -0500
Date: Mon, 10 Dec 2012 22:16:29 +0800
From: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= <chenwj@iis.sinica.edu.tw>
Message-ID: <20121210141629.GA40215@cs.nctu.edu.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH_v3] add target-openrisc floating point
 exception
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Feng Gao <gf91597@gmail.com>
Cc: qemu-devel@nongnu.org

Hi Feng,

  One question,

> @@ -25,5 +25,5 @@  void HELPER(exception)(CPUOpenRISCState *env,
> uint32_t excp)
>  {
>      OpenRISCCPU *cpu =3D OPENRISC_CPU(ENV_GET_CPU(env));
> =20
> -    raise_exception(cpu, excp);
> +    do_raise_exception(cpu, excp, 0);
>  }

  Shouldn't above helper function be called from the code cache?
The 3rd argument of do_raise_exception means if the exception comes
from code cache or not, iiuc. Is it correct to put zero here?

Regards,
chenwj

--=20
Wei-Ren Chen (=E9=99=B3=E9=9F=8B=E4=BB=BB)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj