From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: blauwirbel@gmail.com, "Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register()
Date: Mon, 10 Dec 2012 19:55:42 +0100 [thread overview]
Message-ID: <20121210195542.3e1e1d9f@thinkpad.mammed.net> (raw)
In-Reply-To: <20121210124613.GI4255@otherpad.lan.raisama.net>
On Mon, 10 Dec 2012 10:46:13 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Sun, Dec 09, 2012 at 08:45:50PM +0100, Andreas Färber wrote:
> > Simplifies the upcoming cleanup of cpu_x86_find_by_name().
>
> ...by making cpu_x86_register() more complicated, and having CPU model
> name lookup spread into different parts of the code.
>
> The CPU model lookup is a bit complex because of the "host" exception,
> but at least the complexity was hidden inside cpu_x86_find_by_name()
> (making it very easy to replace that logic by a CPU subclass lookup,
> later).
+1
[...]
>
> --
> Eduardo
>
--
Regards,
Igor
next prev parent reply other threads:[~2012-12-10 18:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 18:32 [Qemu-devel] [PATCH] finally kill cpudef config section support Eduardo Habkost
2012-12-04 18:41 ` Andreas Färber
2012-12-04 18:53 ` Eduardo Habkost
2012-12-08 17:54 ` Blue Swirl
2012-12-08 18:02 ` Andreas Färber
2012-12-08 20:00 ` Blue Swirl
2012-12-09 19:13 ` Andreas Färber
2012-12-09 20:46 ` Blue Swirl
2012-12-10 0:13 ` Andreas Färber
2012-12-12 13:03 ` Eduardo Habkost
2012-12-10 18:03 ` Eduardo Habkost
2012-12-09 19:45 ` [Qemu-devel] [PATCH qom-cpu 0/4] target-i386: Finish killing cpudef support Andreas Färber
2012-12-09 19:45 ` [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register() Andreas Färber
2012-12-10 12:46 ` Eduardo Habkost
2012-12-10 18:55 ` Igor Mammedov [this message]
2012-12-10 23:21 ` Andreas Färber
2012-12-10 23:33 ` Eduardo Habkost
2012-12-09 19:45 ` [Qemu-devel] [PATCH qom-cpu 2/4] target-i386: Drop redundant list of CPU definitions Andreas Färber
2012-12-10 18:22 ` Eduardo Habkost
2012-12-09 19:45 ` [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support Andreas Färber
2012-12-10 18:09 ` Eduardo Habkost
2012-12-10 23:12 ` Andreas Färber
2012-12-10 23:53 ` Eduardo Habkost
2012-12-11 8:41 ` Wenchao Xia
2012-12-09 19:45 ` [Qemu-devel] [PATCH qom-cpu 4/4] MAINTAINERS: Include X86CPU in CPU maintenance area Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210195542.3e1e1d9f@thinkpad.mammed.net \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).