From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti8W5-0002me-TR for qemu-devel@nongnu.org; Mon, 10 Dec 2012 13:55:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti8W4-00030o-RM for qemu-devel@nongnu.org; Mon, 10 Dec 2012 13:55:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti8W4-00030i-BE for qemu-devel@nongnu.org; Mon, 10 Dec 2012 13:55:48 -0500 Date: Mon, 10 Dec 2012 19:55:42 +0100 From: Igor Mammedov Message-ID: <20121210195542.3e1e1d9f@thinkpad.mammed.net> In-Reply-To: <20121210124613.GI4255@otherpad.lan.raisama.net> References: <1354645978-17362-1-git-send-email-ehabkost@redhat.com> <1355082353-322-1-git-send-email-afaerber@suse.de> <1355082353-322-2-git-send-email-afaerber@suse.de> <20121210124613.GI4255@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: blauwirbel@gmail.com, Andreas =?UTF-8?B?RsOkcmJlcg==?= , qemu-devel@nongnu.org On Mon, 10 Dec 2012 10:46:13 -0200 Eduardo Habkost wrote: > On Sun, Dec 09, 2012 at 08:45:50PM +0100, Andreas F=C3=A4rber wrote: > > Simplifies the upcoming cleanup of cpu_x86_find_by_name(). >=20 > ...by making cpu_x86_register() more complicated, and having CPU model > name lookup spread into different parts of the code. >=20 > The CPU model lookup is a bit complex because of the "host" exception, > but at least the complexity was hidden inside cpu_x86_find_by_name() > (making it very easy to replace that logic by a CPU subclass lookup, > later). +1=20 [...] >=20 > --=20 > Eduardo >=20 --=20 Regards, Igor