From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: kwolf@redhat.com, blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call
Date: Tue, 11 Dec 2012 10:21:51 +0100 [thread overview]
Message-ID: <20121211092151.GB30567@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1355140582-5354-1-git-send-email-chouteau@adacore.com>
On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote:
> An error has occurred if the return value is invalid_set_file_pointer
> and getlasterror doesn't return no_error.
>
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
> block/raw-win32.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
The fprintf() is kind of iffy but we only return -EIO so I guess it
helps to print the full error.
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2012-12-11 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 11:56 [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call Fabien Chouteau
2012-12-11 9:21 ` Stefan Hajnoczi [this message]
2012-12-11 10:37 ` Kevin Wolf
2012-12-11 17:44 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211092151.GB30567@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).