From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiM2K-0001AN-Ev for qemu-devel@nongnu.org; Tue, 11 Dec 2012 04:22:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiM2E-00052h-Tg for qemu-devel@nongnu.org; Tue, 11 Dec 2012 04:22:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiM2E-00052a-Ly for qemu-devel@nongnu.org; Tue, 11 Dec 2012 04:21:54 -0500 Date: Tue, 11 Dec 2012 10:21:51 +0100 From: Stefan Hajnoczi Message-ID: <20121211092151.GB30567@stefanha-thinkpad.muc.redhat.com> References: <1355140582-5354-1-git-send-email-chouteau@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355140582-5354-1-git-send-email-chouteau@adacore.com> Subject: Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: kwolf@redhat.com, blauwirbel@gmail.com, qemu-devel@nongnu.org On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote: > An error has occurred if the return value is invalid_set_file_pointer > and getlasterror doesn't return no_error. > > Signed-off-by: Fabien Chouteau > --- > block/raw-win32.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) The fprintf() is kind of iffy but we only return -EIO so I guess it helps to print the full error. Acked-by: Stefan Hajnoczi