From: Stefan Hajnoczi <stefanha@gmail.com>
To: Tim Hardeck <thardeck@suse.de>
Cc: aliguori@us.ibm.com, github@martintribe.org,
qemu-devel@nongnu.org, alevy@redhat.com, kraxel@redhat.com,
corentin.chary@gmail.com
Subject: Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support
Date: Tue, 11 Dec 2012 11:04:09 +0100 [thread overview]
Message-ID: <20121211100409.GD796@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1354892195-18332-3-git-send-email-thardeck@suse.de>
On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote:
Thanks for addressing my review comments.
> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque)
>
> void vnc_write(VncState *vs, const void *data, size_t len)
> {
> - buffer_reserve(&vs->output, len);
> + buffer_reserve(&vs->output, len);
>
> - if (vs->csock != -1 && buffer_empty(&vs->output)) {
> - qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, vnc_client_write, vs);
> - }
> + if (vs->csock != -1 && buffer_empty(&vs->output)) {
> + qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read,
> + vnc_client_write, vs);
> + }
>
> - buffer_append(&vs->output, data, len);
> + buffer_append(&vs->output, data, len);
QEMU uses 4 spaces for indentation.
Stefan
next prev parent reply other threads:[~2012-12-11 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 14:56 [Qemu-devel] [PATCH 0/3 v4] vnc: added initial websocket protocol support Tim Hardeck
2012-12-07 14:56 ` [Qemu-devel] [PATCH 1/3] vnc: added buffer_advance function Tim Hardeck
2012-12-07 14:56 ` [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support Tim Hardeck
2012-12-11 10:04 ` Stefan Hajnoczi [this message]
2012-12-12 10:04 ` Tim Hardeck
2012-12-12 13:30 ` Stefan Hajnoczi
2012-12-07 14:56 ` [Qemu-devel] [PATCH 3/3] vnc: fix possible uninitialized removals Tim Hardeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211100409.GD796@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@gmail.com \
--cc=alevy@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=corentin.chary@gmail.com \
--cc=github@martintribe.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thardeck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).