From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TiMhK-0006BQ-I1
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 05:04:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TiMhD-0000Va-3a
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 05:04:22 -0500
Received: from mail-qc0-f173.google.com ([209.85.216.173]:59699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TiMhC-0000VP-Vq
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 05:04:15 -0500
Received: by mail-qc0-f173.google.com with SMTP id b12so2104803qca.4
	for <qemu-devel@nongnu.org>; Tue, 11 Dec 2012 02:04:14 -0800 (PST)
Date: Tue, 11 Dec 2012 11:04:09 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121211100409.GD796@stefanha-thinkpad.muc.redhat.com>
References: <1354892195-18332-1-git-send-email-thardeck@suse.de>
	<1354892195-18332-3-git-send-email-thardeck@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1354892195-18332-3-git-send-email-thardeck@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket
	protocol support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tim Hardeck <thardeck@suse.de>
Cc: aliguori@us.ibm.com, github@martintribe.org, qemu-devel@nongnu.org, alevy@redhat.com, kraxel@redhat.com, corentin.chary@gmail.com

On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote:

Thanks for addressing my review comments.

> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque)
>  
>  void vnc_write(VncState *vs, const void *data, size_t len)
>  {
> -    buffer_reserve(&vs->output, len);
> +        buffer_reserve(&vs->output, len);
>  
> -    if (vs->csock != -1 && buffer_empty(&vs->output)) {
> -        qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, vnc_client_write, vs);
> -    }
> +        if (vs->csock != -1 && buffer_empty(&vs->output)) {
> +            qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read,
> +                    vnc_client_write, vs);
> +        }
>  
> -    buffer_append(&vs->output, data, len);
> +        buffer_append(&vs->output, data, len);

QEMU uses 4 spaces for indentation.

Stefan