From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiOg3-0004HQ-Qh for qemu-devel@nongnu.org; Tue, 11 Dec 2012 07:11:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiOfu-0002Np-6V for qemu-devel@nongnu.org; Tue, 11 Dec 2012 07:11:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiOft-0002Ne-Vt for qemu-devel@nongnu.org; Tue, 11 Dec 2012 07:11:02 -0500 Date: Tue, 11 Dec 2012 10:10:59 -0200 From: Luiz Capitulino Message-ID: <20121211101059.0b1cebe1@doriath.home> In-Reply-To: <24E144B8C0207547AD09C467A8259F7557872153@lisa.maurer-it.com> References: <1355168173-14571-1-git-send-email-lcapitulino@redhat.com> <24E144B8C0207547AD09C467A8259F7557870AEE@lisa.maurer-it.com> <20121211094513.29fa32bd@doriath.home> <24E144B8C0207547AD09C467A8259F7557872153@lisa.maurer-it.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer Cc: "aliguori@us.ibm.com" , "agl@us.ibm.com" , "qemu-devel@nongnu.org" , "mdroth@linux.vnet.ibm.com" On Tue, 11 Dec 2012 12:05:32 +0000 Dietmar Maurer wrote: > > > and simply return all stats with one API call (query-ballon)? > > > > We can't use query-balloon because this changes query-balloon from > > synchronous to asynchronous, and this is an incompatible change. > > Why don't we simply cache the last received stats, and query-ballon returns > the cached values? Giving that we're doing this through device properties, we'd duplicate the interface by also returning this info in query-balloon. However, it wouldn't be a problem to extend 'info balloon' (in HMP) with that info. That is, 'info balloon' could use the QOM interface to query balloon stats.