From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1TiPHz-0002ej-04
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 07:50:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1TiPHt-0005KA-52
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 07:50:22 -0500
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:49149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1TiPHs-0005K0-Tp
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 07:50:17 -0500
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Tue, 11 Dec 2012 12:49:59 -0000
Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com
	[9.149.37.247])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id qBBCo6rK4391210
	for <qemu-devel@nongnu.org>; Tue, 11 Dec 2012 12:50:06 GMT
Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id qBBCoCu1007955
	for <qemu-devel@nongnu.org>; Tue, 11 Dec 2012 05:50:13 -0700
Date: Tue, 11 Dec 2012 13:50:10 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20121211135010.36872984@BR9GNB5Z>
In-Reply-To: <7338881F-11E8-4C21-BB81-E02F65DDB73D@suse.de>
References: <1354884626-15060-1-git-send-email-cornelia.huck@de.ibm.com>
	<1354884626-15060-4-git-send-email-cornelia.huck@de.ibm.com>
	<82610216-94CA-44E8-B3CE-EB94886CECFC@suse.de>
	<20121210112726.0697bc4f@BR9GNB5Z>
	<7338881F-11E8-4C21-BB81-E02F65DDB73D@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check
	injection.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: linux-s390 <linux-s390@vger.kernel.org>, Anthony Liguori <aliguori@us.ibm.com>, KVM <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>, Carsten Otte <cotte@de.ibm.com>, Sebastian Ott <sebott@linux.vnet.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>

On Tue, 11 Dec 2012 11:29:16 +0100
Alexander Graf <agraf@suse.de> wrote:

> 
> On 10.12.2012, at 11:27, Cornelia Huck wrote:
> 
> > On Mon, 10 Dec 2012 09:20:57 +0100
> > Alexander Graf <agraf@suse.de> wrote:
> > 
> >> 
> >> On 07.12.2012, at 13:50, Cornelia Huck wrote:

> >>> +        /* CRW machine checks disabled */
> >>> +        return;
> >>> +    }
> >>> +
> >>> +    lowcore = cpu_physical_memory_map(env->psa, &len, 1);
> >> 
> >> Check missing again.
> > 
> > Perhaps we want {map,unmap}_lowcore() functions?
> 
> Awesome idea!

I'll cook up an extra patch for this then (and make the ext stuff use
it).