From: Luiz Capitulino <lcapitulino@redhat.com>
To: Dietmar Maurer <dietmar@proxmox.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
mdroth <mdroth@linux.vnet.ibm.com>,
"agl@us.ibm.com" <agl@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats
Date: Tue, 11 Dec 2012 17:23:55 -0200 [thread overview]
Message-ID: <20121211172355.3ee96cd4@doriath.home> (raw)
In-Reply-To: <24E144B8C0207547AD09C467A8259F755788040D@lisa.maurer-it.com>
On Tue, 11 Dec 2012 19:07:48 +0000
Dietmar Maurer <dietmar@proxmox.com> wrote:
> > I could move the check for the stats feature bit from the function that
> > enables polling to the timer callback. This would solve Dietmar's use-case,
>
> that would be great.
>
> > but it would silently fail if the feature is never negotiated (as you said
> > above).
>
> Why don't we raise the error when we query the values?
Hmm, that's a good idea.
Only small nit is that, today old stats will remain available to be queried
even if you disable the timer. If we do what you suggest, old stats won't
be available if the module is unloaded (well, I *guess* the guest will unset
the feature bit on module removal).
next prev parent reply other threads:[~2012-12-11 19:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 19:36 [Qemu-devel] [PATCH 0/3] re-enable balloon stats Luiz Capitulino
2012-12-10 19:36 ` [Qemu-devel] [PATCH 1/3] virtio-balloon: drop old stats code Luiz Capitulino
2012-12-10 19:36 ` [Qemu-devel] [PATCH 2/3] virtio-balloon: re-enable balloon stats Luiz Capitulino
2012-12-10 19:36 ` [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats Luiz Capitulino
2012-12-11 5:12 ` [Qemu-devel] [PATCH 0/3] re-enable balloon stats Dietmar Maurer
2012-12-11 11:45 ` Luiz Capitulino
2012-12-11 12:05 ` Dietmar Maurer
2012-12-11 12:10 ` Luiz Capitulino
2012-12-11 12:29 ` Dietmar Maurer
2012-12-11 12:59 ` Luiz Capitulino
2012-12-11 15:14 ` Dietmar Maurer
2012-12-11 17:38 ` mdroth
2012-12-11 18:28 ` Luiz Capitulino
2012-12-11 18:30 ` Luiz Capitulino
2012-12-11 19:07 ` Dietmar Maurer
2012-12-11 19:23 ` Luiz Capitulino [this message]
2012-12-11 19:39 ` Dietmar Maurer
2012-12-11 19:41 ` Luiz Capitulino
2012-12-12 13:17 ` Dietmar Maurer
2012-12-12 13:29 ` Luiz Capitulino
2012-12-12 13:36 ` Dietmar Maurer
2012-12-12 13:40 ` Luiz Capitulino
2012-12-12 13:45 ` Dietmar Maurer
2012-12-13 12:41 ` Luiz Capitulino
2012-12-11 22:26 ` mdroth
2012-12-12 5:56 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211172355.3ee96cd4@doriath.home \
--to=lcapitulino@redhat.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=dietmar@proxmox.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).