From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tin9r-0004yf-BQ for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:19:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tin9k-0003ke-5R for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:19:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tin9j-0003kN-Ur for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:19:28 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCEJRhm004682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Dec 2012 09:19:27 -0500 Date: Wed, 12 Dec 2012 16:22:38 +0200 From: "Michael S. Tsirkin" Message-ID: <20121212142238.GB15555@redhat.com> References: <1353320494-15033-1-git-send-email-pbonzini@redhat.com> <50C88C97.3020105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C88C97.3020105@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, kraxel@redhat.com On Wed, Dec 12, 2012 at 02:54:31PM +0100, Paolo Bonzini wrote: > Il 19/11/2012 11:21, Paolo Bonzini ha scritto: > > Five small, boring patches. Inspired by Gerd's patch at > > http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05229.html which > > unfortunately is already out of date. > > > > Paolo Bonzini (5): > > docs: move pci-ids.txt to docs/specs/ > > reorganize pci-ids.txt > > virtio-9p: use symbolic constant, add to pci-ids.txt > > ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt > > pci: use constants for devices under the 1B36 device ID, document them > > > > docs/specs/pci-ids.txt | 49 ++++++++++++++++++++++++++++++++++++++++++++++ > > hw/9pfs/virtio-9p-device.c | 2 +- > > hw/ivshmem.c | 2 +- > > hw/pci.h | 9 +++++++++ > > hw/pci_bridge_dev.c | 8 ++------ > > hw/serial-pci.c | 12 ++++++------ > > pci-ids.txt | 31 ----------------------------- > > 7 file modificati, 68 inserzioni(+), 45 rimozioni(-) > > create mode 100644 docs/specs/pci-ids.txt > > delete mode 100644 pci-ids.txt > > > > Ping? > > Paolo Sent one question otherwise looks fine to me.