From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt
Date: Wed, 12 Dec 2012 17:35:14 +0200 [thread overview]
Message-ID: <20121212153514.GD16750@redhat.com> (raw)
In-Reply-To: <50C8A1AA.7020804@redhat.com>
On Wed, Dec 12, 2012 at 04:24:26PM +0100, Paolo Bonzini wrote:
> Il 12/12/2012 16:21, Michael S. Tsirkin ha scritto:
> > Thinking about it some more, I'd rather move this stuff
> > out of pci.h
> >
> > For virtio, there's actually linux/virtio_ids.h
> > which defines VIRTIO_ID_NET etc. We should add that,
> > and have virtio just use it.
> >
> > Doesn't ivshmem have a linux driver?
>
> No, you use it with mmap of sysfs files. The doorbell feature requires uio.
>
> > When it lands upstream we'll be able to add it to pci_ids.h
> > meanwhile keeping a number in device .c seems fine as well.
>
> I think the point was to avoid conflicts, but as long as docs/specs/ is
> kept in sync that's fine.
Right. We are not the final authority on device/vendor IDs anyway -
I am more worried about using the correct IDs for emulated devices.
> > I will do the virtio change I think - meanwhile
> > could you limit this patch to just the .txt change please?
>
> Ok, will resend.
>
> Paolo
next prev parent reply other threads:[~2012-12-12 15:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 10:21 [Qemu-devel] [PATCH 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices Paolo Bonzini
2012-11-19 10:21 ` [Qemu-devel] [PATCH 1/5] docs: move pci-ids.txt to docs/specs/ Paolo Bonzini
2012-11-19 10:21 ` [Qemu-devel] [PATCH 2/5] reorganize pci-ids.txt Paolo Bonzini
2012-11-19 10:21 ` [Qemu-devel] [PATCH 3/5] virtio-9p: use symbolic constant, add to pci-ids.txt Paolo Bonzini
2012-11-19 10:21 ` [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, " Paolo Bonzini
2012-12-12 14:22 ` Michael S. Tsirkin
2012-12-12 14:29 ` Paolo Bonzini
2012-12-12 14:48 ` Michael S. Tsirkin
2012-12-12 14:51 ` Paolo Bonzini
2012-12-12 15:21 ` Michael S. Tsirkin
2012-12-12 15:24 ` Paolo Bonzini
2012-12-12 15:35 ` Michael S. Tsirkin [this message]
2012-11-19 10:21 ` [Qemu-devel] [PATCH 5/5] pci: use constants for devices under the 1B36 device ID, document them Paolo Bonzini
2012-11-19 10:45 ` [Qemu-devel] [PATCH 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices Gerd Hoffmann
2012-12-12 13:54 ` Paolo Bonzini
2012-12-12 14:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212153514.GD16750@redhat.com \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).