From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TioI8-0000R4-T2 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TioI0-0006rt-5c for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:32:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TioHz-0006rj-Ux for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:32:04 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCFW3Ta026861 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Dec 2012 10:32:03 -0500 Date: Wed, 12 Dec 2012 17:35:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20121212153514.GD16750@redhat.com> References: <1353320494-15033-1-git-send-email-pbonzini@redhat.com> <1353320494-15033-5-git-send-email-pbonzini@redhat.com> <20121212142207.GA15555@redhat.com> <50C894CB.9030406@redhat.com> <20121212144854.GG15555@redhat.com> <50C899E4.5020403@redhat.com> <20121212152106.GA16750@redhat.com> <50C8A1AA.7020804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C8A1AA.7020804@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, kraxel@redhat.com On Wed, Dec 12, 2012 at 04:24:26PM +0100, Paolo Bonzini wrote: > Il 12/12/2012 16:21, Michael S. Tsirkin ha scritto: > > Thinking about it some more, I'd rather move this stuff > > out of pci.h > > > > For virtio, there's actually linux/virtio_ids.h > > which defines VIRTIO_ID_NET etc. We should add that, > > and have virtio just use it. > > > > Doesn't ivshmem have a linux driver? > > No, you use it with mmap of sysfs files. The doorbell feature requires uio. > > > When it lands upstream we'll be able to add it to pci_ids.h > > meanwhile keeping a number in device .c seems fine as well. > > I think the point was to avoid conflicts, but as long as docs/specs/ is > kept in sync that's fine. Right. We are not the final authority on device/vendor IDs anyway - I am more worried about using the correct IDs for emulated devices. > > I will do the virtio change I think - meanwhile > > could you limit this patch to just the .txt change please? > > Ok, will resend. > > Paolo