From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TioLG-0002tF-IR for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:35:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TioL9-0007ZX-8T for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:35:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TioL9-0007ZL-1K for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:35:19 -0500 Date: Wed, 12 Dec 2012 17:38:21 +0200 From: "Michael S. Tsirkin" Message-ID: <20121212153821.GA17446@redhat.com> References: <1355322396-32026-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355322396-32026-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, agraf@suse.de On Wed, Dec 12, 2012 at 03:26:34PM +0100, Paolo Bonzini wrote: > virtio devices are not performing a full reset when zero is written > to the status field, because the reset does not propagate down the qdev > bus hierarchy. > > These patches fix this problem by calling qdev_reset_all when zero > is written to the status field. Looks like this is a virtio-scsi thing - others don't have a hierarchy. Let's just stick this code in virtio_scsi_reset then? It likely can access the scsi bus without going through virtio-pci and s390 right? > Paolo Bonzini (2): > virtio-pci: reset all qbuses too when writing to the status field > virtio-s390: reset all qbuses too when writing to the status field > > hw/s390-virtio-bus.c | 8 +++++++- > hw/virtio-pci.c | 25 ++++++++++--------------- > 2 files changed, 17 insertions(+), 16 deletions(-) > > -- > 1.8.0.1